linux-kernel - Re: [PATCH v2 3/7] regulator: rk808: Migrate to regulator core's simplified DT parsing code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160421160120.GT3217@sirena.org.uk>
Date:	Thu, 21 Apr 2016 17:01:20 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Wadim Egorov <w.egorov@...tec.de>
Cc:	linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
	rtc-linux@...glegroups.com, devicetree@...r.kernel.org,
	linux-rockchip@...ts.infradead.org, robh+dt@...nel.org,
	pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	mturquette@...libre.com, sboyd@...eaurora.org,
	lee.jones@...aro.org, lgirdwood@...il.com, a.zummo@...ertech.it,
	alexandre.belloni@...e-electrons.com, dianders@...omium.org,
	zyw@...k-chips.com
Subject: Re: [PATCH v2 3/7] regulator: rk808: Migrate to regulator core's
 simplified DT parsing code

On Thu, Apr 21, 2016 at 03:12:37PM +0200, Wadim Egorov wrote:

> +static int rk808_set_suspend_voltage(struct regulator_dev *rdev, int uv)
> +{
> +	unsigned int reg;
> +	int sel = regulator_map_voltage_linear(rdev, uv, uv);
> +
> +	if (sel < 0)
> +		return -EINVAL;
> +
> +	reg = rdev->desc->vsel_reg + RK808_SLP_REG_OFFSET;
> +
> +	return regmap_update_bits(rdev->regmap, reg,
> +				  rdev->desc->vsel_mask,
> +				  sel);
> +}

This is fine but is adding a new feature and not part of the refactoring
that the changelog talked about so should be in a separate commit.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)