linux-kernel - Re: [PATCH] lib/mpi: Fix kernel unaligned acces in mpi_write_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160421174442.GD25698@oracle.com>
Date:	Thu, 21 Apr 2016 13:44:42 -0400
From:	Sowmini Varadhan <sowmini.varadhan@...cle.com>
To:	Tadeusz Struk <tadeusz.struk@...el.com>
Cc:	linux-kernel@...r.kernel.org, herbert@...dor.apana.org.au,
	smueller@...onox.de, mmarek@...e.com, arnd@...db.de,
	andrew.zaborowski@...el.com
Subject: Re: [PATCH] lib/mpi: Fix kernel unaligned acces in mpi_write_to_sgl

On (04/21/16 10:23), Tadeusz Struk wrote:
> 
> What if the mpi_limb_t will happen to be 64 bit? 
> Thanks,

When I checked this with cscope, I found

typedef unsigned long int mpi_limb_t;

thus I used the *32 functions. 

But you obviously know better, since you wrote this code (and bug).
If you anticipate that mpi_limb_t in some environment today,
I can check for sizeof(mpi_limb_t), and predicate it to
use the *32 or *64 functions based on the result. Do you think that
is necessary?

Regards,
--Sowmini