linux-kernel - Re: [PATCH net-next] perf, bpf: minimize the size of perf_trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160421.134955.768804097889808245.davem@davemloft.net>
Date:	Thu, 21 Apr 2016 13:49:55 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ast@...com
Cc:	rostedt@...dmis.org, peterz@...radead.org, mingo@...nel.org,
	daniel@...earbox.net, acme@...radead.org, wangnan0@...wei.com,
	jbacik@...com, brendan.d.gregg@...il.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-team@...com
Subject: Re: [PATCH net-next] perf, bpf: minimize the size of perf_trace_()
 tracepoint handler

From: Alexei Starovoitov <ast@...com>
Date: Mon, 18 Apr 2016 20:11:50 -0700

> move trace_call_bpf() into helper function to minimize the size
> of perf_trace_*() tracepoint handlers.
>     text	   data	    bss	    dec	 	   hex	filename
> 10541679	5526646	2945024	19013349	1221ee5	vmlinux_before
> 10509422	5526646	2945024	18981092	121a0e4	vmlinux_after
> 
> It may seem that perf_fetch_caller_regs() can also be moved,
> but that is incorrect, since ip/sp will be wrong.
> 
> bpf+tracepoint performance is not affected, since
> perf_swevent_put_recursion_context() is now inlined.
> export_symbol_gpl can also be dropped.
> 
> No measurable change in normal perf tracepoints.
> 
> Suggested-by: Steven Rostedt <rostedt@...dmis.org>
> Signed-off-by: Alexei Starovoitov <ast@...nel.org>

Applied, thanks Alexei.