linux-kernel - Re: [PATCH] drivers: net: cpsw: fix wrong regs access in cpsw_ndo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 21 Apr 2016 14:31:09 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	grygorii.strashko@...com
Cc:	netdev@...r.kernel.org, mugunthanvnm@...com, nsekhar@...com,
	linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org
Subject: Re: [PATCH] drivers: net: cpsw: fix wrong regs access in
 cpsw_ndo_open

From: Grygorii Strashko <grygorii.strashko@...com>
Date: Tue, 19 Apr 2016 21:09:49 +0300

> The cpsw_ndo_open() could try to access CPSW registers before
> calling pm_runtime_get_sync(). This will trigger L3 error:
> 
>  WARNING: CPU: 0 PID: 21 at drivers/bus/omap_l3_noc.c:147 l3_interrupt_handler+0x220/0x34c()
>  44000000.ocp:L3 Custom Error: MASTER M2 (64-bit) TARGET L4_FAST (Idle): Data Access in Supervisor mode during Functional access
> 
> and CPSW will stop functioning.
> 
> Hence, fix it by moving pm_runtime_get_sync() before the first access
> to CPSW registers in cpsw_ndo_open().
> 
> Signed-off-by: Grygorii Strashko <grygorii.strashko@...com>

Applied, thanks.