linux-kernel - Re: [PATCH V3 05/11] staging: mt29f_spinand: set ECC algorithm explicitly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 21 Apr 2016 22:20:56 +0200
From:	Boris Brezillon <boris.brezillon@...e-electrons.com>
To:	Rafał Miłecki <zajec5@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	linux-mtd@...ts.infradead.org,
	Eva Rachel Retuya <eraretuya@...il.com>,
	Brian Norris <computersforpeace@...il.com>,
	Manuel Pégourié-Gonnard 
	<mpg@...evir.fr>, Janani Ravichandran <janani.rvchndrn@...il.com>,
	devel@...verdev.osuosl.org (open list:STAGING SUBSYSTEM),
	linux-kernel@...r.kernel.org (open list)
Subject: Re: [PATCH V3 05/11] staging: mt29f_spinand: set ECC algorithm
 explicitly

Hi Greg,

On Sun, 17 Apr 2016 22:53:01 +0200
Rafał Miłecki <zajec5@...il.com> wrote:

> This is part of process deprecating NAND_ECC_SOFT_BCH (and switching to
> enum nand_ecc_algo).

Do you mind if I take this patch through the NAND tree in order to avoid
dependency problems?

> 
> Signed-off-by: Rafał Miłecki <zajec5@...il.com>
> ---
>  drivers/staging/mt29f_spinand/mt29f_spinand.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/mt29f_spinand/mt29f_spinand.c b/drivers/staging/mt29f_spinand/mt29f_spinand.c
> index f503699..e389009 100644
> --- a/drivers/staging/mt29f_spinand/mt29f_spinand.c
> +++ b/drivers/staging/mt29f_spinand/mt29f_spinand.c
> @@ -900,6 +900,7 @@ static int spinand_probe(struct spi_device *spi_nand)
>  	chip->ecc.write_page = spinand_write_page_hwecc;
>  #else
>  	chip->ecc.mode	= NAND_ECC_SOFT;
> +	chip->ecc.algo	= NAND_ECC_HAMMING;
>  	if (spinand_disable_ecc(spi_nand) < 0)
>  		dev_info(&spi_nand->dev, "%s: disable ecc failed!\n",
>  			 __func__);



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com