linux-kernel - Re: [PATCH v2 2/2] asus-laptop: correct error handling in sysfs_acpi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 21 Apr 2016 23:34:13 +0300
From:	Andy Shevchenko <andy.shevchenko@...il.com>
To:	Giedrius Statkevičius 
	<giedrius.statkevicius@...il.com>
Cc:	Corentin Chary <corentin.chary@...il.com>,
	"dvhart@...radead.org" <dvhart@...radead.org>,
	acpi4asus-user@...ts.sourceforge.net,
	platform-driver-x86@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] asus-laptop: correct error handling in sysfs_acpi_set

On Sat, Apr 16, 2016 at 3:01 AM, Giedrius Statkevičius
<giedrius.statkevicius@...il.com> wrote:
> Properly return rv back to the caller in the case of an error in
> parse_arg. In the process remove a unused variable 'out'.
>
> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@...il.com>
> ---
>  drivers/platform/x86/asus-laptop.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
> index d86d42e..9a69734 100644
> --- a/drivers/platform/x86/asus-laptop.c
> +++ b/drivers/platform/x86/asus-laptop.c
> @@ -946,11 +946,10 @@ static ssize_t sysfs_acpi_set(struct asus_laptop *asus,
>                               const char *method)
>  {
>         int rv, value;
> -       int out = 0;
>
>         rv = parse_arg(buf, count, &value);

Just noticed (might be a separate patch for this) that parse_arg
pretty much duplicated kstrotint().

> -       if (rv > 0)
> -               out = value ? 1 : 0;
> +       if (rv <= 0)
> +               return rv;
>
>         if (write_acpi_int(asus->handle, method, value))
>                 return -ENODEV;
> --
> 2.8.0
>



-- 
With Best Regards,
Andy Shevchenko