linux-kernel - Re: [PATCH] rtc: snvs: return error in case enable_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160421232214.GE29844@piout.net>
Date:	Fri, 22 Apr 2016 01:22:14 +0200
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	Stefan Agner <stefan@...er.ch>
Cc:	a.zummo@...ertech.it, rtc-linux@...glegroups.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtc: snvs: return error in case enable_irq_wake fails

On 20/04/2016 at 16:09:57 -0700, Stefan Agner wrote :
> If enable_irq_wake fails, we should return that error code so that
> entering suspend fails. Otherwise we will get a WARNING along with
> the hint of a unbalanced wake disable:
> Unbalanced IRQ 37 wake disable
> 
> Signed-off-by: Stefan Agner <stefan@...er.ch>
> ---
>  drivers/rtc/rtc-snvs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com