linux-kernel - Re: [PATCH] usb: core: Do not use sizeof on pointer type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 22 Apr 2016 08:57:52 +0200
From:	Bjørn Mork <bjorn@...k.no>
To:	Vaishali Thakkar <vaishali.thakkar@...cle.com>
Cc:	gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: core: Do not use sizeof on pointer type

Vaishali Thakkar <vaishali.thakkar@...cle.com> writes:

> When sizeof is applied to a pointer typed expression, it gives
> the size of the pointer. So, do not use sizeof on pointer type.

What if the intended result was the size of the pointer?

> Problem found using Coccinelle.

Yes, sure.  But you cannot just blindly apply the result without reading
and understanding the code.

Bjørn