[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20160422094137.GB3217@sirena.org.uk>
Date: Fri, 22 Apr 2016 10:41:37 +0100
From: Mark Brown <broonie@...nel.org>
To: Wadim Egorov <w.egorov@...tec.de>
Cc: linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
rtc-linux@...glegroups.com, devicetree@...r.kernel.org,
linux-rockchip@...ts.infradead.org, robh+dt@...nel.org,
pawel.moll@....com, mark.rutland@....com,
ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
mturquette@...libre.com, sboyd@...eaurora.org,
lee.jones@...aro.org, lgirdwood@...il.com, a.zummo@...ertech.it,
alexandre.belloni@...e-electrons.com, dianders@...omium.org,
zyw@...k-chips.com
Subject: Re: [PATCH v2 3/7] regulator: rk808: Migrate to regulator core's
simplified DT parsing code
On Fri, Apr 22, 2016 at 11:03:09AM +0200, Wadim Egorov wrote:
> On 21.04.2016 18:01, Mark Brown wrote:
> >> +static int rk808_set_suspend_voltage(struct regulator_dev *rdev, int uv)
> >> +{
> > This is fine but is adding a new feature and not part of the refactoring
> > that the changelog talked about so should be in a separate commit.
> This is not really a new feature.
> rk808_set_suspend_voltage() was using regulator_map_voltage_linear_range().
> I have just renamed the function to rk808_set_suspend_voltage_range()
> and added an ops struct for ranges.
> Yes, I have also added rk808_set_suspend_voltage(), but this is just a split
> for the two types of ops that the driver needs now.
> This was needed, because the driver used only linear ranges.
> IMO it should be a part of the refactoring.
If that's the case then split this into multiple refactorings each doing
one change so this can be more easily reviewed.
Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)
Powered by blists - more mailing lists