linux-kernel - [tip:x86/boot] tools/lguest: Force disable tboot and APM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 22 Apr 2016 02:51:29 -0700
From:	"tip-bot for Luis R. Rodriguez" <tipbot@...or.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	torvalds@...ux-foundation.org, hpa@...or.com, mingo@...nel.org,
	mcgrof@...nel.org, bp@...en8.de, tglx@...utronix.de,
	luto@...capital.net, brgerst@...il.com, peterz@...radead.org,
	dvlasenk@...hat.com, linux-kernel@...r.kernel.org,
	rusty@...tcorp.com.au
Subject: [tip:x86/boot] tools/lguest: Force disable tboot and APM

Commit-ID:  46504590321dc62a11065f8d00e1b12037c37018
Gitweb:     http://git.kernel.org/tip/46504590321dc62a11065f8d00e1b12037c37018
Author:     Luis R. Rodriguez <mcgrof@...nel.org>
AuthorDate: Wed, 13 Apr 2016 17:04:37 -0700
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Fri, 22 Apr 2016 10:29:03 +0200

tools/lguest: Force disable tboot and APM

The paravirt_enabled() check is going away, the area tossed to
the kernel on lguest is not zeroed out, so ensure lguest force
disables tboot and APM just in case the kernel file being read
might have this set for whatever reason.

Signed-off-by: Luis R. Rodriguez <mcgrof@...nel.org>
Acked-by: Rusty Russell <rusty@...tcorp.com.au>
Cc: Andy Lutomirski <luto@...capital.net>
Cc: Borislav Petkov <bp@...en8.de>
Cc: Brian Gerst <brgerst@...il.com>
Cc: Denys Vlasenko <dvlasenk@...hat.com>
Cc: H. Peter Anvin <hpa@...or.com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: andrew.cooper3@...rix.com
Cc: andriy.shevchenko@...ux.intel.com
Cc: bigeasy@...utronix.de
Cc: boris.ostrovsky@...cle.com
Cc: david.vrabel@...rix.com
Cc: ffainelli@...ebox.fr
Cc: george.dunlap@...rix.com
Cc: glin@...e.com
Cc: jgross@...e.com
Cc: jlee@...e.com
Cc: josh@...htriplett.org
Cc: julien.grall@...aro.org
Cc: konrad.wilk@...cle.com
Cc: kozerkov@...allels.com
Cc: lenb@...nel.org
Cc: lguest@...ts.ozlabs.org
Cc: linux-acpi@...r.kernel.org
Cc: lv.zheng@...el.com
Cc: matt@...eblueprint.co.uk
Cc: mbizon@...ebox.fr
Cc: rjw@...ysocki.net
Cc: robert.moore@...el.com
Cc: tiwai@...e.de
Cc: toshi.kani@...com
Cc: xen-devel@...ts.xensource.com
Link: http://lkml.kernel.org/r/1460592286-300-8-git-send-email-mcgrof@kernel.org
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 tools/lguest/lguest.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tools/lguest/lguest.c b/tools/lguest/lguest.c
index ff0aa580..d9836c5 100644
--- a/tools/lguest/lguest.c
+++ b/tools/lguest/lguest.c
@@ -3357,6 +3357,12 @@ int main(int argc, char *argv[])
 	/* Tell the entry path not to try to reload segment registers. */
 	boot->hdr.loadflags |= KEEP_SEGMENTS;
 
+	/* We don't support tboot: */
+	boot->tboot_addr = 0;
+
+	/* Ensure this is 0 to prevent APM from loading: */
+	boot->apm_bios_info.version = 0;
+
 	/* We tell the kernel to initialize the Guest. */
 	tell_kernel(start);