linux-kernel - Re: [patch] spi: pic32-sqi: silence array overflow warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5719F5B5.2030101@microchip.com>
Date:	Fri, 22 Apr 2016 15:28:13 +0530
From:	Purna Chandra Mandal <purna.mandal@...rochip.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
CC:	Mark Brown <broonie@...nel.org>, <linux-spi@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [patch] spi: pic32-sqi: silence array overflow warning

On 04/22/2016 03:25 PM, Dan Carpenter wrote:

> We read one element beyond the end of the array when we access
> "rdesc[i + 1]" so it causes a static checker warning.  It's harmless
> because we write over it again on the next line.  But let's just silence
> the warning.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
>
> diff --git a/drivers/spi/spi-pic32-sqi.c b/drivers/spi/spi-pic32-sqi.c
> index b215347..74b9e68 100644
> --- a/drivers/spi/spi-pic32-sqi.c
> +++ b/drivers/spi/spi-pic32-sqi.c
> @@ -537,7 +537,7 @@ static int ring_desc_ring_alloc(struct pic32_sqi *sqi)
>  	}
>  
>  	/* Prepare BD: chain to next BD(s) */
> -	for (i = 0, rdesc = sqi->ring; i < PESQI_BD_COUNT; i++)
> +	for (i = 0, rdesc = sqi->ring; i < PESQI_BD_COUNT - 1; i++)
>  		bd[i].bd_nextp = rdesc[i + 1].bd_dma;
>  	bd[PESQI_BD_COUNT - 1].bd_nextp = 0;
>
Reviewed-by: Purna Chandra Mandal <purna.mandal@...rochip.com>