linux-kernel - Re: [PATCH] cpuidle: Indicate when a device has been unregistered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <17196985.m6DKFEgqnD@vostro.rjw.lan>
Date:	Fri, 22 Apr 2016 02:40:56 +0200
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Daniel Lezcano <daniel.lezcano@...aro.org>,
	Dave Gerlach <d-gerlach@...com>
Cc:	linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH] cpuidle: Indicate when a device has been unregistered

On Wednesday, April 06, 2016 12:00:48 PM Daniel Lezcano wrote:
> On Tue, Apr 05, 2016 at 02:05:38PM -0500, Dave Gerlach wrote:
> > Currently the 'registered' member of the cpuidle_device struct is set
> > to 1 during cpuidle_register_device. In this same function there are
> > checks to see if the device is already registered to prevent duplicate
> > calls to register the device, but this value is never set to 0 even on
> > unregister of the device. Because of this, any attempt to call
> > cpuidle_register_device after a call to cpuidle_unregister_device will
> > fail which shouldn't be the case.
> > 
> > To prevent this, set registered to 0 when the device is unregistered.
> > 
> > Fixes: c878a52d3c7c ("cpuidle: Check if device is already registered")
> > Signed-off-by: Dave Gerlach <d-gerlach@...com>
> > ---
> 
> Acked-by: Daniel Lezcano <daniel.lezcano@...aro.org>

Applied, thanks!