linux-kernel - Re: [PATCH] regulator: core: Add debugfs for regulator always

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160422135709.GE3217@sirena.org.uk>
Date:	Fri, 22 Apr 2016 14:57:09 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Richard Fitzgerald <rf@...nsource.wolfsonmicro.com>
Cc:	lgirdwood@...il.com, patches@...nsource.wolfsonmicro.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator: core: Add debugfs for regulator always_on flag

On Fri, Apr 22, 2016 at 02:33:02PM +0100, Richard Fitzgerald wrote:
> This patch adds a debugfs file for the always_on flag in struct regulator.
> It's useful for debugging to be able to view the state of this flag and
> as it's set by logic inside the regulator core it doesn't necessarily have
> the same value as the always_on flag in constraints.

Why not include this in the same file as the rest of the constraints?
Or why not have one file per constraint (which would be easier for
scripts)?

> +	ret = snprintf(buf, PAGE_SIZE, "always_on: %u\n", regulator->always_on);

> +		debugfs_create_file("always_on", 0444, regulator->debugfs,

It seems to be formatted as though it's going to end up in the same file
but it's a separate file so instead it's just repeating the name of the
file inside the file.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)