linux-kernel - Re: [PATCH] regulator: arizona-ldo1: Only enable status change if we have LDOENA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160422150446.GF3217@sirena.org.uk>
Date:	Fri, 22 Apr 2016 16:04:46 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Richard Fitzgerald <rf@...nsource.wolfsonmicro.com>
Cc:	lgirdwood@...il.com, patches@...nsource.wolfsonmicro.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator: arizona-ldo1: Only enable status change if we
 have LDOENA

On Fri, Apr 22, 2016 at 02:43:28PM +0100, Richard Fitzgerald wrote:
> The driver was hardcoding REGULATOR_CHANGE_STATUS on the regulator
> which made the regulator core assume that it can be powered off.
> 
> The power state of the regulator is controlled by the LDOENA pin so
> this patch changes to only setting the REGULATOR_CHANGE_STATUS flag
> if we have a valid gpio for LDOENA.

What's the difference between this and the previous version of the patch
and what problem is this aiming to solve?  If we want to disable the
regulator why would we not be happy to do that by removing the supply?

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)