linux-kernel - Re: [PATCH] irqdomain: fix compare_const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <571A7733.9070306@nvidia.com>
Date:	Fri, 22 Apr 2016 20:10:43 +0100
From:	Jon Hunter <jonathanh@...dia.com>
To:	Julia Lawall <julia.lawall@...6.fr>
CC:	Jiang Liu <jiang.liu@...ux.intel.com>,
	Marc Zyngier <marc.zyngier@....com>,
	Thomas Gleixner <tglx@...utronix.de>,
	<linux-kernel@...r.kernel.org>, <kbuild-all@...org>
Subject: Re: [PATCH] irqdomain: fix compare_const_fl.cocci warnings


On 22/04/16 20:00, Julia Lawall wrote:
> On Fri, 22 Apr 2016, Jon Hunter wrote:
> 
>>
>> On 20/04/16 17:49, Julia Lawall wrote:
>>>  Move constants to the right of binary operators.
>>>
>>> Generated by: scripts/coccinelle/misc/compare_const_fl.cocci
>>>
>>> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
>>> Signed-off-by: Julia Lawall <julia.lawall@...6.fr>
>>> ---
>>>
>>> Not a big deal, but the transformed code looks better to me.
>>>
>>>  irqdomain.c |    2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> --- a/kernel/irq/irqdomain.c
>>> +++ b/kernel/irq/irqdomain.c
>>> @@ -618,7 +618,7 @@ unsigned int irq_create_fwspec_mapping(s
>>>  		 * If the trigger type has not been set yet, then set
>>>  		 * it now and return the interrupt number.
>>>  		 */
>>> -		if (IRQ_TYPE_NONE == irq_get_trigger_type(virq)) {
>>> +		if (irq_get_trigger_type(virq) == IRQ_TYPE_NONE) {
>>>  			irq_set_irq_type(virq, type);
>>>  			return virq;
>>>  		}
>>
>> What branch is this from? Looks very familiar and related to some
>> changes I have been working on, but in my latest version I already have
>> this as shown above [0].
> 
> Sorry, I didn't save that information.  If it's done, it's done.  Sorry 
> for the noise.

No problem. I am wondering if this was based off an earlier branch on my
github tree (as I know that kbuild is trawling these) and I have never
posted a patch publicly with the above.

Cheers
Jon