linux-kernel - Re: [PATCH 1/4] pnp: pnpbios: Add explicit X86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <571AB8F6.50802@intel.com>
Date:	Sat, 23 Apr 2016 01:51:19 +0200
From:	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>
To:	William Breathitt Gray <vilhelm.gray@...il.com>
Cc:	tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
	gregkh@...uxfoundation.org, x86@...nel.org,
	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
	alsa-devel@...a-project.org
Subject: Re: [PATCH 1/4] pnp: pnpbios: Add explicit X86_32 dependency to
 PNPBIOS

On 4/11/2016 3:25 PM, William Breathitt Gray wrote:
> The PNPBIOS driver requires preprocessor defines (located in
> include/asm/segment.h) only declared if the architecture is set to
> X86_32. If the architecture is set to X86_64, the PNPBIOS driver will
> not build properly. The X86 dependecy for the PNPBIOS configuration
> option is changed to an explicit X86_32	dependency in order to prevent
> an attempt to build for an unsupported architecture.
>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> Signed-off-by: William Breathitt Gray <vilhelm.gray@...il.com>

Has anyone taken care of this already?

If not, can you possibly resend this patch with a CC to 
linux-acpi@...r.kernel.org so I can pick it up via Patchwork more easily?

> ---
>   drivers/pnp/pnpbios/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pnp/pnpbios/Kconfig b/drivers/pnp/pnpbios/Kconfig
> index 50c3dd0..a786086 100644
> --- a/drivers/pnp/pnpbios/Kconfig
> +++ b/drivers/pnp/pnpbios/Kconfig
> @@ -3,7 +3,7 @@
>   #
>   config PNPBIOS
>   	bool "Plug and Play BIOS support"
> -	depends on ISA && X86
> +	depends on ISA && X86_32
>   	default n
>   	---help---
>   	  Linux uses the PNPBIOS as defined in "Plug and Play BIOS