linux-kernel - Re: [PATCH 1/2] EDAC, altera: remove useless casts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160423100113.GB8531@pd.tnic>
Date:	Sat, 23 Apr 2016 12:01:13 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Thor Thayer <tthayer@...nsource.altera.com>,
	Doug Thompson <dougthompson@...ssion.com>,
	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	Alan Tull <atull@...nsource.altera.com>,
	Dinh Nguyen <dinguyen@...nsource.altera.com>,
	linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] EDAC, altera: remove useless casts

On Sat, Apr 16, 2016 at 10:13:55PM +0200, Arnd Bergmann wrote:
> The altera EDAC driver refers to its per-device data
> using a cast to '(void *)', which makes the pointer
> non-const, though both the source and destination are
> actually const.
> 
> Removing the annotation makes the reference (almost)
> fit into a single line for improved readability, and
> ensures that it is actually defined as const.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/edac/altera_edac.c | 15 ++++++---------
>  1 file changed, 6 insertions(+), 9 deletions(-)

Both applied, thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.