linux-kernel - Re: [PATCH v7 02/15] i2c: octeon: Use i2c recovery framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 25 Apr 2016 23:29:13 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Jan Glauber <jglauber@...ium.com>
Cc:	linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
	David Daney <ddaney@...iumnetworks.com>
Subject: Re: [PATCH v7 02/15] i2c: octeon: Use i2c recovery framework

On Mon, Apr 25, 2016 at 04:33:31PM +0200, Jan Glauber wrote:
> Switch to the i2c bus recovery framework using generic SCL recovery.
> If this fails try to reset the hardware. The recovery is triggered
> during START on timeout of the interrupt or failure to reach
> the START / repeated-START condition.
> 
> The START function is moved to xfer and while at it remove the
> xfer debug message (i2c core already provides a debug message
> for this).
> 
> Signed-off-by: Jan Glauber <jglauber@...ium.com>

Applied to for-next, thanks!

Fixed this checkpatch warning:

CHECK: Please don't use multiple blank lines
#32: FILE: drivers/i2c/busses/i2c-octeon.c:157:

> +	return (ret) ? ret : -EAGAIN;

I'd write 'return ret ?: -EAGAIN' but this is a 'mileage varies' thing.


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)