linux-kernel - Re: [PATCH] perf tools: replace assignment with comparison on assert check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 26 Apr 2016 06:33:17 +0900
From:	Masami Hiramatsu <mhiramat@...nel.org>
To:	Colin King <colin.king@...onical.com>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf tools: replace assignment with comparison on
 assert check

On Sat, 23 Apr 2016 14:45:54 +0100
Colin King <colin.king@...onical.com> wrote:

> From: Colin Ian King <colin.king@...onical.com>
> 
> The current assert check is checking an assignment, which will always
> be true.  Instead, the assert should be checking if scale is equal
> to 0.122
> 

Looks good to me.

Reviewed-by: Masami Hiramatsu <mhiramat@...nel.org>

> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  tools/perf/tests/event_update.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/tests/event_update.c b/tools/perf/tests/event_update.c
> index 012eab5..63ecf21 100644
> --- a/tools/perf/tests/event_update.c
> +++ b/tools/perf/tests/event_update.c
> @@ -30,7 +30,7 @@ static int process_event_scale(struct perf_tool *tool __maybe_unused,
>  
>  	TEST_ASSERT_VAL("wrong id", ev->id == 123);
>  	TEST_ASSERT_VAL("wrong id", ev->type == PERF_EVENT_UPDATE__SCALE);
> -	TEST_ASSERT_VAL("wrong scale", ev_data->scale = 0.123);
> +	TEST_ASSERT_VAL("wrong scale", ev_data->scale == 0.123);
>  	return 0;
>  }
>  
> -- 
> 2.7.4
> 


-- 
Masami Hiramatsu <mhiramat@...nel.org>