linux-kernel - Re: [PATCH] soc: brcmstb: select SOC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 25 Apr 2016 16:00:31 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Arnd Bergmann <arnd@...db.de>,
	Brian Norris <computersforpeace@...il.com>,
	Gregory Fong <gregory.0xf0@...il.com>,
	Florian Fainelli <f.fainelli@...il.com>
Cc:	linux-arm-kernel@...ts.infradead.org,
	bcm-kernel-feedback-list@...adcom.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] soc: brcmstb: select SOC_BUS

On 25/04/16 15:55, Arnd Bergmann wrote:
> The newly added code for the SoC bus fails to link if the
> bus is not built:
> 
> drivers/soc/built-in.o: In function `brcmstb_soc_device_init':
> :(.init.text+0x110): undefined reference to `soc_device_register'
> 
> This adds a 'select' statement to avoid the error.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Fixes: cef4bafcea2c ("soc: brcmstb: add SoC driver to brcmstb")

Acked-by: Florian Fainelli <f.fainelli@...il.com>

Thanks!

> ---
>  drivers/soc/brcmstb/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/soc/brcmstb/Kconfig b/drivers/soc/brcmstb/Kconfig
> index 39cab3b..7fec3b4 100644
> --- a/drivers/soc/brcmstb/Kconfig
> +++ b/drivers/soc/brcmstb/Kconfig
> @@ -1,6 +1,7 @@
>  menuconfig SOC_BRCMSTB
>  	bool "Broadcom STB SoC drivers"
>  	depends on ARM
> +	select SOC_BUS
>  	help
>  	  Enables drivers for the Broadcom Set-Top Box (STB) series of chips.
>  	  This option alone enables only some support code, while the drivers
> 


-- 
Florian