linux-kernel - Re: [PATCH] tools: hv: lsvmbus: add pci pass-through UUID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87potex8pr.fsf@vitty.brq.redhat.com>
Date:	Mon, 25 Apr 2016 12:51:12 +0200
From:	Vitaly Kuznetsov <vkuznets@...hat.com>
To:	Dexuan Cui <decui@...rosoft.com>
Cc:	"devel\@linuxdriverproject.org" <devel@...uxdriverproject.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
	"KY Srinivasan" <kys@...rosoft.com>,
	Haiyang Zhang <haiyangz@...rosoft.com>
Subject: Re: [PATCH] tools: hv: lsvmbus: add pci pass-through UUID

Dexuan Cui <decui@...rosoft.com> writes:

>> From: Vitaly Kuznetsov [mailto:vkuznets@...hat.com]
>> Sent: Saturday, April 23, 2016 0:21
>> To: devel@...uxdriverproject.org
>> Cc: linux-kernel@...r.kernel.org; KY Srinivasan <kys@...rosoft.com>; Haiyang
>> Zhang <haiyangz@...rosoft.com>; Dexuan Cui <decui@...rosoft.com>
>> Subject: [PATCH] tools: hv: lsvmbus: add pci pass-through UUID
>> 
>> lsvmbus keeps its own copy of all VMBus UUIDs, add PCIe pass-through
>> device there to not report 'Unknown' for such devices.
>> 
>> Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com>
>> ---
>>  tools/hv/lsvmbus | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/tools/hv/lsvmbus b/tools/hv/lsvmbus
>> index 162a378..e223284 100644
>> --- a/tools/hv/lsvmbus
>> +++ b/tools/hv/lsvmbus
>> @@ -35,6 +35,7 @@ vmbus_dev_dict = {
>>  	'{ba6163d9-04a1-4d29-b605-72e2ffb1dc7f}' : 'Synthetic SCSI Controller',
>>  	'{2f9bcc4a-0069-4af3-b76b-6fd0be528cda}' : 'Synthetic fiber channel
>> adapter',
>>  	'{8c2eaf3d-32a7-4b09-ab99-bd1f1c86b501}' : 'Synthetic RDMA adapter',
>> +        '{44c4f61d-4444-4400-9d52-802e27ede19f}' : 'PCI Express pass-through',
> Please use TAB rather than 8 space chars here. :-)
>

Oops, I was pretty sure checkpatch.pl catches such issues but apparently
it doesn't work for python scripts. And my text editor failed me as well)

>>  	'{276aacf4-ac15-426c-98dd-7521ad3f01fe}' : '[Reserved system device]',
>>  	'{f8e65716-3cb3-4a06-9a60-1889c5cccab5}' : '[Reserved system
>> device]',
>>  	'{3375baf4-9e15-4b30-b765-67acb10d607b}' : '[Reserved system
>> device]',
>> --
>
> Looks good to me except for the space/TAB issue.

Sure, will send v2.

-- 
  Vitaly