linux-kernel - Re: [PATCH] drm: msm: remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAF6AEGt+46Ps7rBCD3+S+9jeHH3Q+mqorrmAxX9btka-KPz=gQ@mail.gmail.com>
Date:	Mon, 25 Apr 2016 07:47:00 -0400
From:	Rob Clark <robdclark@...il.com>
To:	Arnd Bergmann <arnd@...db.de>, Dave Airlie <airlied@...il.com>
Cc:	David Airlie <airlied@...ux.ie>,
	Archit Taneja <architt@...eaurora.org>,
	Daniel Vetter <daniel.vetter@...ll.ch>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm: msm: remove unused variable

On Sun, Apr 24, 2016 at 6:15 PM, Arnd Bergmann <arnd@...db.de> wrote:
> On Saturday 16 April 2016 16:49:08 Rob Clark wrote:
>> On Sat, Apr 16, 2016 at 4:41 PM, Arnd Bergmann <arnd@...db.de> wrote:
>> > A recent cleanup removed the only user of the 'kms' variable in
>> > msm_preclose(), causing a harmless compiler warning:
>> >
>> > drivers/gpu/drm/msm/msm_drv.c: In function 'msm_preclose':
>> > drivers/gpu/drm/msm/msm_drv.c:468:18: error: unused variable 'kms' [-Werror=unused-variable]
>> >
>> > This removes the variable as well.
>> >
>> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
>> > Fixes: 4016260ba47a ("drm/msm: fix bug after preclose removal")
>>
>> thanks, I'll pull that in for 4.7.. danvet actually pointed that out
>> to me yesterday (a needed fix of a fix.. ;-))
>
> I just realized that this is now the only defconfig warning we get in v4.6 with
> a recent compiler. Any chance we can still squeeze this in the current release?

I don't have anything else to send for -fixes at the moment, but

Signed-off-by: Rob Clark <robdclark@...il.com>

Dave, if you are sending another -fixes, mind grabbing this:

  git pw apply -s 5827

(or if you are still on the old pw, 'pwclient git-am 8277241')

BR,
-R

>         Arnd