linux-kernel - Re: [PATCH v2] uapi glibc compat: fix compile errors when glibc net/if.h included before linux/if.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 25 Apr 2016 15:13:35 +0300
From:	Mikko Rapeli <mikko.rapeli@....fi>
To:	Szabolcs Nagy <szabolcs.nagy@....com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Zhang Shengju <zhangshengju@...s.chinamobile.com>,
	Stephen Hemminger <stephen@...workplumber.org>,
	linux-kernel@...r.kernel.org, Jan Engelhardt <jengelh@...i.de>,
	Josh Boyer <jwboyer@...oraproject.org>,
	Waldemar Brodkorb <mail@...demar-brodkorb.de>,
	Gabriel Laskar <gabriel@....epita.fr>,
	netfilter-devel@...r.kernel.org, libc-alpha@...rceware.org,
	Rich Felker <dalias@...c.org>, nd <nd@....com>
Subject: Re: [PATCH v2] uapi glibc compat: fix compile errors when glibc
 net/if.h included before linux/if.h

On Mon, Apr 25, 2016 at 12:26:09PM +0100, Szabolcs Nagy wrote:
> On 24/04/16 16:45, Mikko Rapeli wrote:
> > glibc's net/if.h contains copies of definitions from linux/if.h and these
> > conflict and cause build failures if both files are included by application
> > source code. Changes in uapi headers, which fixed header file dependencies to
> > include linux/if.h when it was needed, e.g. commit 1ffad83d, made the
> > net/if.h and linux/if.h incompatibilities visible as build failures for
> > userspace applications like iproute2 and xtables-addons.
> > 
> > This patch fixes compile errors when glibc net/if.h is included before
> > linux/if.h:
> > 
> 
> there should be a way to turn the conflicting definitions
> off if a libc header is included first. (the other direction
> won't work in general because linux definitions can be wrong
> for user space.)
>
> currently the only way to avoid the conflict is to define
> __GLIBC__ and a handful of glibc include guard macros that
> are not part of any public api, so a libc implementation
> might not want to do this.
> 
> e.g. the kernel could turn off the potentially conflicting
> definitions if the libc defines __LIBC_WANTS_NO_UAPI_DEFS
> (it can use finer grain control, but there should be a
> non-glibc specific way to do this).

True. Maybe Linux kernel could allow non-glibc userspace headers to define
__UAPI_DEF's as they wish but fall back to a default 1 as in lines after:

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/include/uapi/linux/libc-compat.h#n118

But sometimes users run old libc's and want to use shiny features from newer
kernel and thus use kernel headers for some extra definitions to existing
libc headers and use them in system calls.

Driver specific ioctl's are a good example.

-Mikko