linux-kernel - Re: [PATCH RESEND 2/5] USB: serial: cp210x: Made sure SERIAL_XOFF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <469850ff-86e5-85ad-0144-e19a788d7752@cogentembedded.com>
Date:	Mon, 25 Apr 2016 15:25:04 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Konstantin Shkolnyy <konstantin.shkolnyy@...il.com>,
	johan@...nel.org
Cc:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND 2/5] USB: serial: cp210x: Made sure
 SERIAL_XOFF_CONTINUE flag is clear.

Hello.

On 4/24/2016 8:09 PM, Konstantin Shkolnyy wrote:

> The CRTCTS flag code intended to clear the SERIAL_XOFF_CONTINUE flag, but

    CRTSCTS? Also, "is" missing before "intended"?

> did it inconsistently. This change is non-functional for existing chips
> because the driver never set the flag and it's clear by default.

    Sets.

> Signed-off-by: Konstantin Shkolnyy <konstantin.shkolnyy@...il.com>
[...]

MBR, Sergei