linux-kernel - Re: [PATCH v7 1/4] i2c: tegra: disable clock before returning error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160425135448.GA5897@katana>
Date:	Mon, 25 Apr 2016 15:54:48 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Shardar Shariff Md <smohammed@...dia.com>
Cc:	ldewangan@...dia.com, swarren@...dotorg.org,
	thierry.reding@...il.com, gnurou@...il.com,
	linux-i2c@...r.kernel.org, linux-tegra@...r.kernel.org,
	linux-kernel@...r.kernel.org, jonathanh@...dia.com
Subject: Re: [PATCH v7 1/4] i2c: tegra: disable clock before returning error

On Mon, Apr 25, 2016 at 07:08:36PM +0530, Shardar Shariff Md wrote:
> Disable clock before returning error in tegra_i2c_init() as its leaves
> i2c clock ON in case of error and never turns off again as it will have
> unbalanced clock enable/disable
> 
> Signed-off-by: Shardar Shariff Md <smohammed@...dia.com>
> 
> ---
> Changes in v5:
> - Move current patch as separate patch
> 
> Changes in v6:
> - Remove unnecessary line
> 
> Changes in v7
> - Updated commit message with description of issue

I know 'release often' but maybe you could wait like a day and collect
review responses before submitting a new version? That would make my
life as a maintainer easier...


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)