linux-kernel - Re: [PATCHv3 1/5] efi/runtime-wrappers: detect FW irq flag corruption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160425141557.GA2829@codeblueprint.co.uk>
Date:	Mon, 25 Apr 2016 15:15:57 +0100
From:	Matt Fleming <matt@...eblueprint.co.uk>
To:	Robin Murphy <robin.murphy@....com>
Cc:	Mark Rutland <mark.rutland@....com>, linux-efi@...r.kernel.org,
	linux@....linux.org.uk, ard.biesheuvel@...aro.org,
	catalin.marinas@....com, will.deacon@....com,
	linux-kernel@...r.kernel.org, leif.lindholm@...aro.org,
	mingo@...hat.com, hpa@...or.com, tglx@...utronix.de,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCHv3 1/5] efi/runtime-wrappers: detect FW irq flag corruption

On Mon, 25 Apr, at 03:12:01PM, Robin Murphy wrote:
> >+static void efi_call_virt_check_flags(unsigned long flags, const char *call)
> >+{
> >+	unsigned long cur_flags;
> >+	bool mismatch;
> >+
> >+	local_save_flags(cur_flags);
> >+
> >+	mismatch = !!((cur_flags ^ flags) & ARCH_EFI_IRQ_FLAGS_MASK);
> 
> nit: the assignment itself is already a conversion to bool, so the
> excitement is redundant here.

This was intentional. I asked Mark to make this change so that it's
explicit for the developer that we're performing the type conversion.