linux-kernel - Re: [PATCH 1/1] [RFC] workqueue: fix ghost PENDING flag while doing MQ IO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 25 Apr 2016 18:40:59 +0200
From:	Roman Penyaev <roman.penyaev@...fitbricks.com>
To:	Tejun Heo <tj@...nel.org>
Cc:	Jens Axboe <axboe@...nel.dk>, linux-block@...r.kernel.org,
	linux-kernel@...r.kernel.org, David Howells <dhowells@...hat.com>
Subject: Re: [PATCH 1/1] [RFC] workqueue: fix ghost PENDING flag while doing
 MQ IO

On Mon, Apr 25, 2016 at 6:00 PM, Tejun Heo <tj@...nel.org> wrote:
> On Mon, Apr 25, 2016 at 11:48:47AM -0400, Tejun Heo wrote:
>> Heh, excellent debugging.  I wonder how old this bug is.  cc'ing David
>
> I just went through the history.  So, we used to have clear_bit()
> instead of atomic_long_set() but clear_bit() doesn't imply any barrier
> either, so kudos to you.  You just debugged an issue which is most
> likely has been there for over a decade! :)

That's nice, that we can finally fix it.
But as I was saying I was just lucky enough to have very easy reproduction.
I could check all crazy ideas I had :)

--
Roman