linux-kernel - Re: [PATCH] drm: rcar: remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4434458.QD7L4MnxGs@avalon>
Date:	Mon, 25 Apr 2016 20:04:54 +0300
From:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	David Airlie <airlied@...ux.ie>,
	Daniel Vetter <daniel.vetter@...ll.ch>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Koji Matsuoka <koji.matsuoka.xm@...esas.com>,
	Alexey Brodkin <Alexey.Brodkin@...opsys.com>,
	dri-devel@...ts.freedesktop.org, linux-renesas-soc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm: rcar: remove unused variable

Hi Arnd,

Thank you for the patch.

On Monday 25 Apr 2016 15:11:08 Arnd Bergmann wrote:
> A cleanup for the rcar-du driver left an unused variable behind:
> 
> drm/rcar-du/rcar_du_drv.c: In function 'rcar_du_probe':
> drm/rcar-du/rcar_du_drv.c:300:24: error: unused variable 'connector'
> [-Werror=unused-variable]
> 
> This removes the variable.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: d63c25e4245a ("drm: rcar-du: Use generic drm_connector_register_all()
> helper")

I've already submitted an identical patch and Daniel Vetter has queued it up.

> ---
>  drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 0f251dc11082..fb9242d27883
> 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> @@ -297,7 +297,6 @@ static int rcar_du_probe(struct platform_device *pdev)
>  {
>  	struct device_node *np = pdev->dev.of_node;
>  	struct rcar_du_device *rcdu;
> -	struct drm_connector *connector;
>  	struct drm_device *ddev;
>  	struct resource *mem;
>  	int ret;

-- 
Regards,

Laurent Pinchart