linux-kernel - Re: [alsa-devel] [PATCH 2/3] ASoC: simple-card: Add support jack detection via codec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <9CA36836-11FE-4A7B-8DBC-5A4842D004C6@nh6z.net>
Date:	Mon, 25 Apr 2016 11:17:21 -0700
From:	Jeremy McDermond <nh6z@...z.net>
To:	Mark Brown <broonie@...nel.org>
Cc:	Xing Zheng <zhengxing@...k-chips.com>,
	Mark Rutland <mark.rutland@....com>,
	Andrew Lunn <andrew@...n.ch>, alsa-devel@...a-project.org,
	Mengdong Lin <mengdong.lin@...ux.intel.com>, heiko@...ech.de,
	Liam Girdwood <lgirdwood@...il.com>,
	Takashi Iwai <tiwai@...e.com>, Rob Herring <robh@...nel.org>,
	Aaro Koskinen <aaro.koskinen@....fi>,
	sugar.zhang@...k-chips.com, linux-rockchip@...ts.infradead.org,
	jay.xu@...k-chips.com, devicetree@...r.kernel.org,
	Pawel Moll <pawel.moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Jyri Sarha <jsarha@...com>,
	Arnaud Pouliquen <arnaud.pouliquen@...com>,
	linux-kernel@...r.kernel.org, Adam.Thomson@...semi.com,
	Kumar Gala <galak@...eaurora.org>, Jun Nie <jun.nie@...aro.org>
Subject: Re: [alsa-devel] [PATCH 2/3] ASoC: simple-card: Add support jack detection via codec


> On Apr 25, 2016, at 5:55 AM, Mark Brown <broonie@...nel.org> wrote:
> 
> If the clock code is worth splitting off into a separate driver that's
> what drivers/mfd is for.

I have my doubts that it’s worth splitting off into a separate
driver.  There’s not a lot of use for it outside of the internals of
the tlv320aic3204.  There is a provision for putting the PLL output
on a GPIO pin of the chip, but I’m not sure that’s a justification
for breaking out the clock stuff into its own driver.  Nobody’s going
to put a tlv320aic3204 chip on their boards because of the clocking;
they’re going to put it there to be a codec.

--
Jeremy McDermond (NH6Z)
Xenotropic Systems
mcdermj@...otropic.com