linux-kernel - Re: [PATCH 2/5] iio: inv_mpu6050: Remove inv_mpu6050_hw.num

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46714723-7792-191a-43a0-174e8375324a@kernel.org>
Date:	Mon, 25 Apr 2016 19:43:03 +0100
From:	Jonathan Cameron <jic23@...nel.org>
To:	Crestez Dan Leonard <leonard.crestez@...el.com>,
	linux-iio@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, Hartmut Knaack <knaack.h@....de>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Peter Meerwald-Stadler <pmeerw@...erw.net>,
	Daniel Baluta <daniel.baluta@...el.com>
Subject: Re: [PATCH 2/5] iio: inv_mpu6050: Remove inv_mpu6050_hw.num_reg

On 24/04/16 12:12, Jonathan Cameron wrote:
> On 20/04/16 14:15, Crestez Dan Leonard wrote:
>> This field was unused and incorrect for mpu6500.
>>
>> Signed-off-by: Crestez Dan Leonard <leonard.crestez@...el.com>. 
> This one I think I can safely take :)
> 
> Good spot
Applied.

Thanks,
>> --- 
>>  drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 3 ---
>>  drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h  | 2 --
>>  2 files changed, 5 deletions(-)
>>
>> diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
>> index 52e62b3..faccabafc 100644
>> --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
>> +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
>> @@ -91,19 +91,16 @@ static const struct inv_mpu6050_chip_config chip_config_6050 = {
>>  /* Indexed by enum inv_devices */
>>  static const struct inv_mpu6050_hw hw_info[] = {
>>  	{
>> -		.num_reg = 117,
>>  		.name = "MPU6050",
>>  		.reg = &reg_set_6050,
>>  		.config = &chip_config_6050,
>>  	},
>>  	{
>> -		.num_reg = 117,
>>  		.name = "MPU6500",
>>  		.reg = &reg_set_6500,
>>  		.config = &chip_config_6050,
>>  	},
>>  	{
>> -		.num_reg = 117,
>>  		.name = "MPU6000",
>>  		.reg = &reg_set_6050,
>>  		.config = &chip_config_6050,
>> diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h b/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h
>> index e302a49..c66dbfc 100644
>> --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h
>> +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h
>> @@ -93,13 +93,11 @@ struct inv_mpu6050_chip_config {
>>  
>>  /**
>>   *  struct inv_mpu6050_hw - Other important hardware information.
>> - *  @num_reg:	Number of registers on device.
>>   *  @name:      name of the chip.
>>   *  @reg:   register map of the chip.
>>   *  @config:    configuration of the chip.
>>   */
>>  struct inv_mpu6050_hw {
>> -	u8 num_reg;
>>  	u8 *name;
>>  	const struct inv_mpu6050_reg_map *reg;
>>  	const struct inv_mpu6050_chip_config *config;
>>
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>