[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20160425191815.GA24761@kroah.com>
Date: Mon, 25 Apr 2016 12:18:15 -0700
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Peter Zijlstra <peterz@...radead.org>
Cc: Steven Rostedt <rostedt@...dmis.org>,
Linus Torvalds <torvalds@...ux-foundation.org>,
LKML <linux-kernel@...r.kernel.org>,
Ingo Molnar <mingo@...nel.org>, Borislav Petkov <bp@...en8.de>,
Andrew Morton <akpm@...ux-foundation.org>,
Uwe Kleine-König
<u.kleine-koenig@...gutronix.de>
Subject: Re: [PATCH v2] printk: Add kernel parameter to disable writes to
/dev/kmsg
On Mon, Apr 25, 2016 at 09:06:51PM +0200, Peter Zijlstra wrote:
> On Mon, Apr 25, 2016 at 02:56:06PM -0400, Steven Rostedt wrote:
> > +static bool __read_mostly devkmsg_disabled;
> > +static int __init disable_devkmsg(char *str)
> > +{
> > + devkmsg_disabled = true;
> > + return 0;
> > +}
> > +__setup("printk.disable_kmsg_write", disable_devkmsg);
>
> Again, please default enable and use an easier name to toggle this.
> Userspace flooding this with junk is really insane.
If you default enable, you break working systems today that want to log
stuff through this interface, sorry.
thanks,
greg k-h
Powered by blists - more mailing lists