linux-kernel - Re: [patch] skd: disable broken discard support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <x49wpnl4h6x.fsf@segfault.boston.devel.redhat.com>
Date:	Mon, 25 Apr 2016 15:33:10 -0400
From:	Jeff Moyer <jmoyer@...hat.com>
To:	Jens Axboe <axboe@...nel.dk>
Cc:	linux-kernel@...r.kernel.org, linux-block@...r.kernel.org,
	Thomas Swann <tswann@...c-inc.com>,
	Ramprasad Chinthekindi <rchinthekindi@...c-inc.com>,
	Akhil Bhansali <abhansali@...c-inc.com>
Subject: Re: [patch] skd: disable broken discard support

Jens Axboe <axboe@...nel.dk> writes:

> On 04/25/2016 01:19 PM, Jeff Moyer wrote:
>> Simply creating a file system on an skd device, followed by mount and
>> fstrim will result in errors in the logs, and even a BUG().  Let's
>> disable it.  As far as I can tell, it hasn't worked right since it was
>> merged.  Note that I've only disabled the reporting here, I haven't
>> removed the implementation bits in the code.  Jens, let me know if you
>> want me to yank it out completely.
>
> I agree with yanking it, but let's remove all the support bits as well
> so we don't have dead code around. If someone wants to resurrect it,
> it's all there in the git history anyway.

Sounds good.

Thanks,
Jeff