linux-kernel - Re: [PATCH 3/4] ACPI / osi: Change default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0gOY==-PUNcp-5rsp1mrD=V215rUAWmx6LFM7+CgF=8dA@mail.gmail.com>
Date:	Tue, 26 Apr 2016 22:13:27 +0200
From:	"Rafael J. Wysocki" <rafael@...nel.org>
To:	Lv Zheng <lv.zheng@...el.com>
Cc:	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Len Brown <len.brown@...el.com>, Lv Zheng <zetalog@...il.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
	Chen Yu <yu.c.chen@...el.com>
Subject: Re: [PATCH 3/4] ACPI / osi: Change default _OSI(Darwin) support

On Tue, Apr 26, 2016 at 9:40 AM, Lv Zheng <lv.zheng@...el.com> wrote:
> From: Chen Yu <yu.c.chen@...el.com>
>
> Commit 7bc5a2bad0b8 ("ACPI: Support _OSI("Darwin") correctly") always
> reports positive value when Apple hardware queries _OSI("Darwin"). However
> since this implementation places the judgement in runtime, it breaks
> acpi_osi=!Darwin and cannot return unsupported for _OSI("WinXXX") invoked
> before invoking _OSI("Darwin").
>
> This patch fixes the issues by reverting the wrong support and implementing
> the default behavior of _OSI("Darwin")/_OSI("WinXXX") on Apple hardware via
> DMI matching.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=92111
> Reported-by: Lukas Wunner <lukas@...ner.de>
> Signed-off-by: Chen Yu <yu.c.chen@...el.com>
> Signed-off-by: Lv Zheng <lv.zheng@...el.com>

Why don't you add a Fixes tag pointing to the problematic commit?