linux-kernel - Re: [PATCH v7 09/15] i2c: octeon: Add workaround for broken irqs on CN3860

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160426211759.GD4587@katana>
Date:	Tue, 26 Apr 2016 23:17:59 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Jan Glauber <jglauber@...ium.com>
Cc:	linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
	David Daney <ddaney@...iumnetworks.com>,
	David Daney <david.daney@...ium.com>
Subject: Re: [PATCH v7 09/15] i2c: octeon: Add workaround for broken irqs on
 CN3860

On Mon, Apr 25, 2016 at 04:33:38PM +0200, Jan Glauber wrote:
> From: David Daney <david.daney@...ium.com>
> 
> CN3860 does not interrupt the CPU when the i2c status changes. If
> we get a timeout, and see the status has in fact changed, we know we
> have this problem, and drop back to polling.
> 
> Signed-off-by: David Daney <ddaney@...iumnetworks.com>
> Signed-off-by: Jan Glauber <jglauber@...ium.com>

My code checkers say something:

    CHECKPATCH
CHECK: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt
#37: FILE: drivers/i2c/busses/i2c-octeon.c:390:
+			udelay(50);

CHECK: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt
#70: FILE: drivers/i2c/busses/i2c-octeon.c:529:
+			udelay(50);

Dunno if you want to change that? Seems reasonable to me. Also:

    SMATCH
drivers/i2c/busses/i2c-octeon.c:544 octeon_i2c_hlc_wait() warn: inconsistent indenting

This is true as well.


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)