linux-kernel - Re: [PATCH] drivers/mtd: make maps/uclinux.c driver more explicitly non-modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160426061852.GC25981@localhost>
Date:	Tue, 26 Apr 2016 00:18:52 -0600
From:	Brian Norris <computersforpeace@...il.com>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	linux-kernel@...r.kernel.org,
	David Woodhouse <dwmw2@...radead.org>,
	Greg Ungerer <gerg@...pgear.com>, linux-mtd@...ts.infradead.org
Subject: Re: [PATCH] drivers/mtd: make maps/uclinux.c driver more explicitly
 non-modular

On Sun, Mar 27, 2016 at 12:13:54PM -0400, Paul Gortmaker wrote:
> The Kconfig for this support is currently declared with:
> 
> config MTD_UCLINUX
>         bool "Generic uClinux RAM/ROM filesystem support"
> 
> ...meaning that it currently is not being built as a module by anyone.
> Lets remove as much of the modular evidence that we can, so that when
> reading the driver there is less doubt it is builtin-only.
> 
> Since module_init translates to device_initcall in the non-modular
> case, the init ordering remains unchanged with this commit.
> 
> We also replace module.h with moduleparam.h since the file does use
> a module_param,  and leaving it as such is currently the easiest way
> to remain compatible with existing boot arg use cases.
> 
> We also delete the MODULE_LICENSE tag etc. since all that information
> was (or is now) contained at the top of the file in the comments.
> 
> Cc: David Woodhouse <dwmw2@...radead.org>
> Cc: Brian Norris <computersforpeace@...il.com>
> Cc: Greg Ungerer <gerg@...pgear.com>
> Cc: linux-mtd@...ts.infradead.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>

Applied to l2-mtd.git