linux-kernel - RE: [PATCH] sched: don't output cpu sched info by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <144086DDB7BB6D429C79280EB1C804D40AB769CD@SHSMSX103.ccr.corp.intel.com>
Date:	Tue, 26 Apr 2016 06:39:03 +0000
From:	"Zhang, Yanmin" <yanmin.zhang@...el.com>
To:	Afzal Mohammed <afzal.mohd.ma@...il.com>,
	"Zhang, LongX" <longx.zhang@...el.com>
CC:	"mingo@...hat.com" <mingo@...hat.com>,
	"peterz@...radead.org" <peterz@...radead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] sched: don't output cpu sched info by default

I double-check it.
Function show_state_filter chooses to print all tasks when
state_filter == 0 (TASK_RUNNING).
sysrq_sched_debug_show prints per cpu sched debug info.

They are different info.

It is better to use sched_debug_enabled to control the
2nd part output.

Yanmin

-----Original Message-----
From: Zhang, Yanmin 
Sent: Tuesday, April 26, 2016 9:04 AM
To: Afzal Mohammed; Zhang, LongX
Cc: mingo@...hat.com; peterz@...radead.org; linux-kernel@...r.kernel.org
Subject: RE: [PATCH] sched: don't output cpu sched info by default

Thanks for the pointer. We didn't notice that. That patch also fixes the issue indeed.

Yanmin

-----Original Message-----
From: Afzal Mohammed [mailto:afzal.mohd.ma@...il.com]
Sent: Monday, April 25, 2016 6:50 PM
To: Zhang, LongX
Cc: mingo@...hat.com; peterz@...radead.org; linux-kernel@...r.kernel.org; Zhang, Yanmin
Subject: Re: [PATCH] sched: don't output cpu sched info by default

Hi,

On Mon, Apr 25, 2016 at 01:04:41PM +0800, Zhang Long wrote:

> Android userspace debug prcoess might dump system info by sysrq.
> One info is of cpu sched. Usually, one thread has one line dump.
> Such log is huge sometimes and such dumping spends lots of time and 
> make the system worse. Sometimes, watchdog resets the system in the 
> end.
> 
> The patch fixes it by dumping cpu sched info only when 
> sched_debug_enabled is true.

Doesn't "sched: don't dump sched debug info in SysRq-W" currently in tip/sched/core help ?,

http://lkml.kernel.org/r/1459777322-30902-1-git-send-email-rabin.vincent@axis.com

Regards
afzal