linux-kernel - Re: [PATCH] ARM: debug: remove extraneous DEBUG_HI3716

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <571F2733.6070609@hisilicon.com>
Date:	Tue, 26 Apr 2016 09:30:43 +0100
From:	Wei Xu <xuwei5@...ilicon.com>
To:	Arnd Bergmann <arnd@...db.de>,
	<linux-arm-kernel@...ts.infradead.org>
CC:	Haojian Zhuang <haojian.zhuang@...aro.org>,
	Jiancheng Xue <jchxue@...il.com>,
	Haifeng Yan <yanhaifeng@...il.com>,
	Olof Johansson <olof@...om.net>,
	Russell King <linux@....linux.org.uk>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: debug: remove extraneous DEBUG_HI3716_UART option

Hi Arnd,

On 25/04/2016 14:13, Arnd Bergmann wrote:
> DEBUG_HI3716_UART was supposed to be renamed to DEBUG_HIX5HD2_UART, but
> accidentally both got left in place, which results in a build error when
> CONFIG_DEBUG_UART_PHYS is not set as it should be.
> 
> This removes the old symbol.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: 12aae3097454 ("ARM: debug: Rename Hi3716 to HIX5HD2")
> ---
>  arch/arm/Kconfig.debug | 8 --------
>  1 file changed, 8 deletions(-)

Thanks!
Fine to me.
Should I pick up it and send a pull request or
will you directly pick up it?

Best Regards,
Wei

> 
> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> index 6993978cfd6f..2afd38766707 100644
> --- a/arch/arm/Kconfig.debug
> +++ b/arch/arm/Kconfig.debug
> @@ -268,14 +268,6 @@ choice
>  		  Say Y here if you want kernel low-level debugging support
>  		  on HI3620 UART.
>  
> -	config DEBUG_HI3716_UART
> -		bool "Hisilicon Hi3716 Debug UART"
> -		depends on ARCH_HI3xxx
> -		select DEBUG_UART_PL01X
> -		help
> -		  Say Y here if you want kernel low-level debugging support
> -		  on HI3716 UART.
> -
>  	config DEBUG_HIGHBANK_UART
>  		bool "Kernel low-level debugging messages via Highbank UART"
>  		depends on ARCH_HIGHBANK
>