lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 26 Apr 2016 12:24:32 +0200 From: Nicolas Ferre <nicolas.ferre@...el.com> To: <sergei.shtylyov@...entembedded.com> CC: <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>, Gregory Clement <gregory.clement@...e-electrons.com>, Alexandre Belloni <alexandre.belloni@...e-electrons.com>, <netdev@...r.kernel.org>, Nicolas Ferre <nicolas.ferre@...el.com>, Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net> Subject: [PATCH] ARM: dts: at91: VInCo: fix phy reset gpio flag Fix gpio active flag for the phy reset-gpios property. The line is active low instead of active high. Actually, this flags was never used by the macb driver. Reported-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> Cc: Andrew Lunn <andrew@...n.ch> Cc: David Miller <davem@...emloft.net> Signed-off-by: Nicolas Ferre <nicolas.ferre@...el.com> --- Hi, Thanks for having reported this bug to me. I hope that we will be able to move forward for changing the phy reset code in the macb driver. I plan to queue this patch through arm-soc for 4.7. Thanks, best regards, Nicolas arch/arm/boot/dts/at91-vinco.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/at91-vinco.dts b/arch/arm/boot/dts/at91-vinco.dts index 79aec55e1ebc..6a366ee952a8 100644 --- a/arch/arm/boot/dts/at91-vinco.dts +++ b/arch/arm/boot/dts/at91-vinco.dts @@ -118,7 +118,7 @@ ethernet-phy@1 { reg = <0x1>; - reset-gpios = <&pioE 8 GPIO_ACTIVE_HIGH>; + reset-gpios = <&pioE 8 GPIO_ACTIVE_LOW>; interrupt-parent = <&pioB>; interrupts = <15 IRQ_TYPE_EDGE_FALLING>; }; @@ -162,7 +162,7 @@ reg = <0x1>; interrupt-parent = <&pioB>; interrupts = <31 IRQ_TYPE_EDGE_FALLING>; - reset-gpios = <&pioE 6 GPIO_ACTIVE_HIGH>; + reset-gpios = <&pioE 6 GPIO_ACTIVE_LOW>; }; }; -- 2.1.3
Powered by blists - more mailing lists