linux-kernel - Re: [PATCH] megaraid_sas: trivial fix, add missing space in dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1461632753.2726.108.camel@perches.com>
Date:	Mon, 25 Apr 2016 18:05:53 -0700
From:	Joe Perches <joe@...ches.com>
To:	Colin King <colin.king@...onical.com>,
	Kashyap Desai <kashyap.desai@...gotech.com>,
	Sumit Saxena <sumit.saxena@...gotech.com>,
	Uday Lingala <uday.lingala@...gotech.com>,
	"James E . J . Bottomley" <jejb@...ux.vnet.ibm.com>,
	"Martin K . Petersen" <martin.petersen@...cle.com>,
	Jiri Kosina <trivial@...nel.org>,
	megaraidlinux.pdl@...gotech.com, linux-scsi@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] megaraid_sas: trivial fix, add missing space in dev_err
 message

On Mon, 2016-04-25 at 22:58 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Add a missing space in dev_err message, missed because the string
> spans a few lines.

This is a dev_notice() not dev_err().

> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
[]
> @@ -3345,7 +3345,7 @@ megasas_internal_reset_defer_cmds(struct megasas_instance *instance)
>  			if (!list_empty(&cmd->list)) {
>  				dev_notice(&instance->pdev->dev, "ERROR while"
>  					" moving this cmd:%p, %d %p, it was"
> -					"discovered on some list?\n",
> +					" discovered on some list?\n",
>  					cmd, cmd->sync_cmd, cmd->scmd);
>  
>  				list_del_init(&cmd->list);

Better would be to coalesce the format, but perhaps
this dev_notice should be dev_err?

				dev_notice(&instance->pdev->dev,
					   "ERROR while moving this cmd:%p, %d %p, it was discovered on some list?\n",
					   cmd, cmd->sync_cmd, cmd->scmd);

And the message seems oddly phrased.