linux-kernel - Re: [PATCH] MD: make bio mergeable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <571EC14E.6040703@kernel.dk>
Date:	Mon, 25 Apr 2016 19:15:58 -0600
From:	Jens Axboe <axboe@...nel.dk>
To:	Shaohua Li <shli@...com>, linux-block@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-raid@...r.kernel.org
Cc:	qkrwngud825@...il.com, Kernel-team@...com,
	"v4.3+" <stable@...r.kernel.org>,
	Ming Lei <ming.lei@...onical.com>, Jens Axboe <axboe@...com>,
	Neil Brown <neilb@...e.de>
Subject: Re: [PATCH] MD: make bio mergeable

On 04/25/2016 06:59 PM, Jens Axboe wrote:
> On 04/25/2016 05:52 PM, Shaohua Li wrote:
>> blk_queue_split marks bio unmergeable, which makes sense for normal bio.
>> But if dispatching the bio to underlayer disk, the blk_queue_split
>> checks are invalid, hence it's possible the bio becomes mergeable.
>>
>> In the reported bug, this bug causes trim against raid0 performance slash
>> https://bugzilla.kernel.org/show_bug.cgi?id=117051
>
> Good catch! Will apply for this series, thanks Shaohua.

Actually, let's let that go through the md tree instead. But you can add 
my Reviewed-by, and it'd be nice to get this into 4.6.

-- 
Jens Axboe