linux-kernel - Re: [PATCH] ASoC: omap-pcm: Initialize DMA configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160426130156.GA15388@bitmer.com>
Date:	Tue, 26 Apr 2016 16:01:56 +0300
From:	Jarkko Nikula <jarkko.nikula@...mer.com>
To:	"J.D. Schroeder" <Linux.HWI@...min.com>
Cc:	linux-kernel@...r.kernel.org, peter.ujfalusi@...com,
	lgirdwood@...il.com, broonie@...nel.org, perex@...ex.cz,
	tiwai@...e.com, alsa-devel@...a-project.org,
	linux-omap@...r.kernel.org, Jim Lodes <jim.lodes@...min.com>,
	"J.D. Schroeder" <jay.schroeder@...min.com>
Subject: Re: [PATCH] ASoC: omap-pcm: Initialize DMA configuration

On Mon, Apr 25, 2016 at 11:10:07AM -0500, J.D. Schroeder wrote:
> From: Jim Lodes <jim.lodes@...min.com>
> 
> Initialize the dma_slave_config for PCM DMA transfers,
> instead of leaving it uninitialized. Keeps previous data on
> the stack from giving us invalid values in uninitialized
> members of the config structure.
> 
> Signed-off-by: Jim Lodes <jim.lodes@...min.com>
> Signed-off-by: J.D. Schroeder <jay.schroeder@...min.com>
> ---
>  sound/soc/omap/omap-pcm.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/soc/omap/omap-pcm.c b/sound/soc/omap/omap-pcm.c
> index 99381a2..a84f677 100644
> --- a/sound/soc/omap/omap-pcm.c
> +++ b/sound/soc/omap/omap-pcm.c
> @@ -82,6 +82,8 @@ static int omap_pcm_hw_params(struct snd_pcm_substream *substream,
>  	struct dma_chan *chan;
>  	int err = 0;
>  
> +	memset(&config, 0x00, sizeof(config));

Based on a894bd7fb539 ("ASoC: generic-dmaengine-pcm: Clear slave_config
memory")

Acked-by: Jarkko Nikula <jarkko.nikula@...mer.com>
Reviewed-by: Jarkko Nikula <jarkko.nikula@...mer.com>