linux-kernel - Re: [PATCH] physmap_of: ensure versatile code is reachable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZe04RCxc4BOidZamRqpu3AcmS+xB82v6iM3dXmYx8odA@mail.gmail.com>
Date:	Tue, 26 Apr 2016 16:02:51 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	David Woodhouse <dwmw2@...radead.org>,
	Brian Norris <computersforpeace@...il.com>,
	"linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] physmap_of: ensure versatile code is reachable

On Tue, Apr 26, 2016 at 1:04 AM, Arnd Bergmann <arnd@...db.de> wrote:

> With the newly added physmap_of_versatile code, we get a build error
> when physmap_of is in a module, because of_flash_probe_versatile
> is not exported:
>
> ERROR: "of_flash_probe_versatile" [drivers/mtd/maps/physmap_of.ko] undefined!
>
> This adds the export, and changes the Makefile so that the code is
> also put into a loadable module rather than built-in when physmap_of
> itself is a module.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Argh how stupid of me. Strange I didn't see it on the
build servers. Anyway:
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij