linux-kernel - Re: [PATCH 1/3] mfd: add Cypress FM33256B Processor Companion driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <571F7E60.9040106@gomspace.com>
Date:	Tue, 26 Apr 2016 16:42:40 +0200
From:	Jeppe Ledet-Pedersen <jlp@...space.com>
To:	Rob Herring <robh@...nel.org>
CC:	<lee.jones@...aro.org>, <arnd@...db.de>,
	<gregkh@...uxfoundation.org>,
	<alexandre.belloni@...e-electrons.com>, <a.zummo@...ertech.it>,
	<pawel.moll@....com>, <mark.rutland@....com>,
	<ijc+devicetree@...lion.org.uk>, <galak@...eaurora.org>,
	<rtc-linux@...glegroups.com>, <devicetree@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] mfd: add Cypress FM33256B Processor Companion driver

On 22/04/16 21:32, Rob Herring wrote:
> On Wed, Apr 20, 2016 at 01:07:49PM +0200, Jeppe Ledet-Pedersen wrote:
[snip]
>> +
>> +The MFD exposes two subdevices:
>> +- The FRAM: "cypress,fm33256b-fram"
>> +- The RTC: "cypress,fm33256b-rtc"
>> +
>> +Example:
>> +
>> +spi1: spi@...0800 {
>> +	status = "okay";
>> +	cs-gpios = <&pioC 25 0>;
>> +
>> +	fm33256b@0 {
>> +		compatible = "cypress,fm33256b";
>> +		spi-max-frequency = <10000000>;
>> +		cypress,charge-enabled;
>> +		cypress,charge-fast;
>> +		reg = <0>;
>> +	};
> 
> Where's the 2nd sub device?

Hi Rob,

Right now I just add the two sub-devices using mfd_add_devices in the
fm33256b_probe function in my MFD driver. Would it be better to check
for compatible child nodes before adding each sub-device, like it's done
in drivers/mfd/tc3589x.c?

Thanks,

-Jeppe