lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-Id: <211132EC-6399-491B-852B-5A7F73A2DE00@gmail.com>
Date:	Tue, 26 Apr 2016 20:17:53 +0530
From:	Parth Sane <laerdevstudios@...il.com>
To:	Luis de Bethencourt <luisbg@....samsung.com>
Cc:	Greg KH <gregkh@...uxfoundation.org>, Larry.Finger@...inger.net,
	florian.c.schilhabel@...glemail.com, amitoj1606@...il.com,
	juliana.orod@...il.com,
	"open list:STAGING SUBSYSTEM" <devel@...verdev.osuosl.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6] rtl8712: Fixed alignment to match open parenthesis

Hi,
Yes you are right on that regard. I did do that in my previous patches.
It’s just something that I will have to remember now onwards. Thanks.
Regards,
Parth Sane
> On 26-Apr-2016, at 8:14 PM, Luis de Bethencourt <luisbg@....samsung.com> wrote:
> 
> On 26/04/16 15:33, Parth Sane wrote:
>> Hi,
>> Thanks for the feedback. I did find this issue with the assistance checkpatch.pl script.
>> Regards,
>> Parth Sane
> 
> Normally people mention the checkpatch warning they are fixing.
> 
> For example:
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=5f10ef7dce02d8e36665974aca0977cda58c1122
> 
> Verbosity in the commit message is a good thing :)
> 
> I have tested that your patch still applies cleanly to Greg's staging-testing branch.
> 
> Thanks,
> Luis
> 
>>> On 26-Apr-2016, at 8:00 PM, Luis de Bethencourt <luisbg@....samsung.com> wrote:
>>> 
>>> On 25/04/16 16:43, Parth Sane wrote:
>>>> Fixed alignment to match open parenthesis.
>>>> 
>>>> Signed-off-by: Parth Sane <laerdevstudios@...il.com>
>>>> 
>>>> ---
>>>> Changes in v6:
>>>> 	-Added line before Signed-off message
>>>> 
>>> 
>>> This last version looks good to me. Did you find this issue with checkpatch.pl?
>>> 
>>> Thanks,
>>> Luis
>>> 
>> 


Download attachment "signature.asc" of type "application/pgp-signature" (843 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ