linux-kernel - Re: [PATCH] usb: ehci-platform: add reset controller number in struct ehci_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1604261048080.2038-100000@iolanthe.rowland.org>
Date:	Tue, 26 Apr 2016 10:49:47 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Jiancheng Xue <xuejiancheng@...ilicon.com>
cc:	linux-usb@...r.kernel.org, <linux-kernel@...r.kernel.org>,
	<yanhaifeng@...ilicon.com>, <yanghongwei@...ilicon.com>,
	<zhangzhenxing@...ilicon.com>, <suwenping@...ilicon.com>,
	<raojun@...ilicon.com>, <ml.yang@...ilicon.com>,
	<gaofei@...ilicon.com>, <hermit.wangheming@...ilicon.com>,
	<jiangheng@...ilicon.com>, <lpc.li@...ilicon.com>
Subject: Re: [PATCH] usb: ehci-platform: add reset controller number in struct
 ehci_platform_priv

On Tue, 26 Apr 2016, Jiancheng Xue wrote:

> > If an error occurs here...
> > 
> Sorry. It's really a problem. I'll modify it in v2 like below:
> 
> err = reset_control_deassert(priv->rsts[rst]);
> if(err) {
> 	reset_control_put(priv->rsts[rst]);
> 	goto err_reset;
> }

Yes, that would be good.  (Except for the missing ' ' between "if" and 
"(".)

> Is it OK except this bug? If so, I'll send out v2 patch.

Everything else looked okay to me.

Alan Stern