linux-kernel - Re: [patch] skd: remove broken discard support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <F2A47426-9037-40D6-AF24-F41ED63F1F98@kernel.dk>
Date:	Mon, 25 Apr 2016 19:54:54 -0600
From:	Jens Axboe <axboe@...nel.dk>
To:	Jeff Moyer <jmoyer@...hat.com>
Cc:	Akhil.Bhansali@...t.com, linux-kernel@...r.kernel.org,
	linux-block@...r.kernel.org
Subject: Re: [patch] skd: remove broken discard support


> On Apr 25, 2016, at 4:06 PM, Jeff Moyer <jmoyer@...hat.com> wrote:
> 
> Simply creating a file system on an skd device, followed by mount and
> fstrim will result in errors in the logs and then a BUG().  Let's remove
> discard support from that driver.  As far as I can tell, it hasn't
> worked right since it was merged.  This patch also has a side-effect of
> cleaning up an unintentional shadowed declaration inside of
> skd_end_request.
> 
> I tested to ensure that I can still do I/O to the device using xfstests
> ./check -g quick.  I didn't do anything more extensive than that,
> though.

Applied, thanks Jeff. 

-- 
Jens Axboe