[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20160426152318.GE24104@obsidianresearch.com>
Date: Tue, 26 Apr 2016 09:23:18 -0600
From: Jason Gunthorpe <jgunthorpe@...idianresearch.com>
To: Dennis Dalessandro <dennis.dalessandro@...el.com>
Cc: dledford@...hat.com, linux-rdma@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/7] IB/hfi1: Remove write() and use ioctl() for user
access
On Fri, Apr 22, 2016 at 02:38:45PM -0400, Dennis Dalessandro wrote:
> >Stuff like this should be a build bug:
> >/* NOTE: assumes unsigned long is 8 bytes */
>
> Our Kconfig depends on X86_64. Should we add a BUILD_BUG_ON or something?
Yes
> as we can maintain the same functionality, which seems doable. It's just
> that no one has spoken up about these things in the 9+ months since the
> driver was added. We need a bit of time to get it all sorted out.
Unfortunately this is a bit of a flaw with the staging process, really
it is not designed to handle uAPI work.
Jason
Powered by blists - more mailing lists