linux-kernel - Re: [RFC][PATCH 22/31] locking,tile: Implement atomic{,64}_fetch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <571F8A27.1020706@mellanox.com>
Date:	Tue, 26 Apr 2016 11:32:55 -0400
From:	Chris Metcalf <cmetcalf@...lanox.com>
To:	Peter Zijlstra <peterz@...radead.org>
CC:	<torvalds@...ux-foundation.org>, <mingo@...nel.org>,
	<tglx@...utronix.de>, <will.deacon@....com>,
	<paulmck@...ux.vnet.ibm.com>, <boqun.feng@...il.com>,
	<waiman.long@....com>, <fweisbec@...il.com>,
	<linux-kernel@...r.kernel.org>, <linux-arch@...r.kernel.org>,
	<rth@...ddle.net>, <vgupta@...opsys.com>, <linux@....linux.org.uk>,
	<egtvedt@...fundet.no>, <realmz6@...il.com>,
	<ysato@...rs.sourceforge.jp>, <rkuo@...eaurora.org>,
	<tony.luck@...el.com>, <geert@...ux-m68k.org>,
	<james.hogan@...tec.com>, <ralf@...ux-mips.org>,
	<dhowells@...hat.com>, <jejb@...isc-linux.org>,
	<mpe@...erman.id.au>, <schwidefsky@...ibm.com>, <dalias@...c.org>,
	<davem@...emloft.net>, <jcmvbkbc@...il.com>, <arnd@...db.de>,
	<dbueso@...e.de>, <fengguang.wu@...el.com>
Subject: Re: [RFC][PATCH 22/31] locking,tile: Implement
 atomic{,64}_fetch_{add,sub,and,or,xor}()

On 4/26/2016 11:28 AM, Peter Zijlstra wrote:
> On Mon, Apr 25, 2016 at 04:54:34PM -0400, Chris Metcalf wrote:
>> Otherwise, though just based on code inspection so far:
>>
>> Acked-by: Chris Metcalf <cmetcalf@...lanox.com> [for tile]
> Thanks!
>
> Just to verify; the new fetch-op thingies _do_ indeed need the extra
> smp_mb() as per my patch, because there is no trailing instruction
> depending on the completion of the load?

Exactly.  I should have said so explicitly :-)

-- 
Chris Metcalf, Mellanox Technologies
http://www.mellanox.com