linux-kernel - Re: [PATCH net-next 0/8] netlink: align attributes when needed (patchset #3)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160426.122515.1389035390419695445.davem@davemloft.net>
Date:	Tue, 26 Apr 2016 12:25:15 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	lars.ellenberg@...bit.com
Cc:	nicolas.dichtel@...nd.com, netdev@...r.kernel.org,
	sd@...asysnail.net, johannes@...solutions.net,
	kvalo@...eaurora.org, linux-wireless@...r.kernel.org,
	jack@...e.com, linux-kernel@...r.kernel.org, pshelar@...ira.com,
	dev@...nvswitch.org, jhs@...atatu.com, philipp.reisner@...bit.com,
	drbd-dev@...ts.linbit.com
Subject: Re: [PATCH net-next 0/8] netlink: align attributes when needed
 (patchset #3)

From: Lars Ellenberg <lars.ellenberg@...bit.com>
Date: Tue, 26 Apr 2016 13:54:27 +0200

> On Tue, Apr 26, 2016 at 10:06:10AM +0200, Nicolas Dichtel wrote:
>> 
>> This is the continuation (series #3) of the work done to align netlink
>> attributes when these attributes contain some 64-bit fields.
>> 
>> It's the last patchset from what I've seen.
>> 
>> The last user of nla_put_u64() is block/drbd. This module does not use
>> standard netlink API (see all the stuff in include/linux/genl_magic_struct.h
>> and include/linux/genl_magic_func.h). I didn't modify it because it's seems
>> hard to do it whithout testing and fully understanding the context
> 
> Something like this should just work.

Unfortunately we had problems using unspec, that's why an explicit new
padding attribute is added for each netlink attribute set.