linux-kernel - Re: [PATCH] watchdog: trivial fix of spelling mistake on "allocate"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160426165000.GA30901@roeck-us.net>
Date:	Tue, 26 Apr 2016 09:50:00 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Joe Perches <joe@...ches.com>
Cc:	Colin King <colin.king@...onical.com>,
	Wim Van Sebroeck <wim@...ana.be>,
	Jiri Kosina <trivial@...nel.org>,
	linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: trivial fix of spelling mistake on "allocate"

On Mon, Apr 25, 2016 at 10:22:19PM -0700, Joe Perches wrote:
> On Mon, 2016-04-25 at 20:19 +0100, Colin King wrote:
> > fix spelling mistake, alloacate -> allocate
> []
> > diff --git a/drivers/watchdog/jz4740_wdt.c b/drivers/watchdog/jz4740_wdt.c
> []
> > @@ -161,7 +161,7 @@ static int jz4740_wdt_probe(struct platform_device *pdev)
> >  	drvdata = devm_kzalloc(&pdev->dev, sizeof(struct jz4740_wdt_drvdata),
> >  			       GFP_KERNEL);
> >  	if (!drvdata) {
> > -		dev_err(&pdev->dev, "Unable to alloacate watchdog device\n");
> > +		dev_err(&pdev->dev, "Unable to allocate watchdog device\n");
> 
> Might as well delete this line instead.
> 
Excellent point.

Colin, please resend and just drop the error message. It is not needed
because an error message is already printed by devm_kzalloc().

Thanks,
Guenter